Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Sync by default #2208

Closed
darkdh opened this issue Nov 21, 2018 · 2 comments · Fixed by brave/brave-core#943
Closed

Enable Sync by default #2208

darkdh opened this issue Nov 21, 2018 · 2 comments · Fixed by brave/brave-core#943
Assignees
@darkdh
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.58.x - Release ...

Comments

@darkdh
Copy link
Member

darkdh commented Nov 21, 2018 •
edited
Loading

No description provided.

@darkdh darkdh added this to the 0.58.x - Dev milestone Nov 21, 2018
@darkdh darkdh self-assigned this Nov 21, 2018
@darkdh darkdh mentioned this issue Nov 21, 2018
Merged
18 tasks
@darkdh darkdh added the QA/Yes label Nov 21, 2018
@srirambv
Copy link
Contributor

srirambv commented Dec 11, 2018 •
edited by btlechowski
Loading

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Running --disable-brave-sync doesn't show Brave sync option in hamburger menu
  • Running --disable-brave-sync doesn't show Brave sync in brave://extensions
  • Running --disable-brave-sync and the visiting brave://bravesync loads an error page

Verified passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification Passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 11, 2018 •
edited by LaurenWags
Loading

Blocked on Windows due to #2450
Blocked on MacOS due to #2450

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Set sync to default enabled and provide "disable-brave-sync" switch brave/brave-core
6 participants
@kjozwiak @darkdh @srirambv @LaurenWags @btlechowski @GeetaSarvadnya