Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add 1p ephemeral storage support #8881

Closed
wants to merge 9 commits into from
Closed

WIP Add 1p ephemeral storage support #8881

wants to merge 9 commits into from

Conversation

goodov
Copy link
Member

@goodov goodov commented May 20, 2021

Resolves brave/brave-browser#15906

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested review from bridiver and a team as code owners May 20, 2021 15:33
@goodov goodov force-pushed the issues/15906 branch 5 times, most recently from 080a8f8 to a29c0bf Compare May 26, 2021 14:36
@goodov goodov force-pushed the issues/15906 branch 4 times, most recently from 0893d02 to 1479a0b Compare May 31, 2021 15:47
@goodov goodov force-pushed the issues/15906 branch 3 times, most recently from b6e85c8 to 905e15e Compare June 10, 2021 14:24
@goodov goodov requested review from a team as code owners June 21, 2021 13:40
@iefremov
Copy link
Contributor

can be closed @goodov ?

@goodov goodov closed this Oct 26, 2021
@goodov goodov deleted the issues/15906 branch October 26, 2021 13:33
@goodov
Copy link
Member Author

goodov commented Oct 26, 2021

fully implemented in #9624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement 1p Ephemeral Storage Functionality (functionality)
2 participants