Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify ephemeral storage trigger logic to use net::CookieOptions. #9095

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

goodov
Copy link
Member

@goodov goodov commented Jun 11, 2021

This PR generalizes ephemeral storage check to allow it to be used in 1p context. Also this PR restores navigation cookie handling in ephemeral storage mode (which is required for 1p-ES).
The idea is to fill net::CookieOptions with ephemeral storage values everywhere it's required and then use it in CookieMonster directly.

All planned changes can be seen here: #8881. This is a first part to simplify the PR review process.

Issue: brave/brave-browser#15906

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested review from a team as code owners June 11, 2021 07:12
@goodov goodov self-assigned this Jun 11, 2021
@@ -470,7 +470,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest,
}

IN_PROC_BROWSER_TEST_F(EphemeralStorageBrowserTest,
DISABLED_NavigationCookiesArePartitioned) {
NavigationCookiesArePartitioned) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the name of this test because "navigation cookies" doesn't mean anything to me. This is presumably for network cookies?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually what we really need is to check network and JS for all tests now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extended/added tests to check network and JS cookie set.

@goodov goodov force-pushed the issues/15906-cookieoptions-migration branch from 45ef6c8 to 02e9189 Compare June 28, 2021 12:50
@goodov goodov force-pushed the issues/15906-cookieoptions-migration branch from 02e9189 to e5225e0 Compare June 28, 2021 13:04
@goodov goodov merged commit aa3746b into master Jun 29, 2021
@goodov goodov deleted the issues/15906-cookieoptions-migration branch June 29, 2021 06:42
@goodov goodov added this to the 1.28.x - Nightly milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants