Don't reuse cached storages for another Page.

brave · Jun 21, 2021 · 47e6c36 · 47e6c36
1 parent 905e15e
commit 47e6c36
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/chromium_src/third_party/blink/renderer/modules/storage/brave_dom_window_storage.h b/chromium_src/third_party/blink/renderer/modules/storage/brave_dom_window_storage.h
@@ -10,6 +10,7 @@
 
 namespace blink {
 
+class EphemeralStorageNamespaces;
 class ExceptionState;
 class LocalDOMWindow;
 class StorageArea;
@@ -35,6 +36,7 @@ class BraveDOMWindowStorage final
   StorageArea* ephemeralSessionStorage();
   StorageArea* ephemeralLocalStorage();
 
+  mutable Member<EphemeralStorageNamespaces> ephemeral_storage_namespaces_;
   mutable Member<StorageArea> ephemeral_session_storage_;
   mutable Member<StorageArea> ephemeral_local_storage_;
 };

diff --git a/chromium_src/third_party/blink/renderer/modules/storage/dom_window_storage.cc b/chromium_src/third_party/blink/renderer/modules/storage/dom_window_storage.cc
@@ -181,16 +181,20 @@ StorageArea* BraveDOMWindowStorage::sessionStorage(
 }
 
 StorageArea* BraveDOMWindowStorage::ephemeralSessionStorage() {
-  if (ephemeral_session_storage_)
-    return ephemeral_session_storage_;
-
   LocalDOMWindow* window = GetSupplementable();
   Page* page = window->GetFrame()->GetDocument()->GetPage();
   EphemeralStorageNamespaces* namespaces =
       EphemeralStorageNamespaces::From(page, window);
   if (!namespaces)
     return nullptr;
 
+  if (ephemeral_session_storage_ &&
+      ephemeral_storage_namespaces_ == namespaces) {
+    return ephemeral_session_storage_;
+  }
+
+  ephemeral_storage_namespaces_ = namespaces;
+
   auto storage_area =
       namespaces->session_storage()->GetCachedArea(window->GetSecurityOrigin());
 
@@ -213,16 +217,19 @@ StorageArea* BraveDOMWindowStorage::localStorage(
 }
 
 StorageArea* BraveDOMWindowStorage::ephemeralLocalStorage() {
-  if (ephemeral_local_storage_)
-    return ephemeral_local_storage_;
-
   LocalDOMWindow* window = GetSupplementable();
   Page* page = window->GetFrame()->GetDocument()->GetPage();
   EphemeralStorageNamespaces* namespaces =
       EphemeralStorageNamespaces::From(page, window);
   if (!namespaces)
     return nullptr;
 
+  if (ephemeral_local_storage_ && ephemeral_storage_namespaces_ == namespaces) {
+    return ephemeral_local_storage_;
+  }
+
+  ephemeral_storage_namespaces_ = namespaces;
+
   auto storage_area =
       namespaces->local_storage()->GetCachedArea(window->GetSecurityOrigin());
 
@@ -237,6 +244,7 @@ StorageArea* BraveDOMWindowStorage::ephemeralLocalStorage() {
 }
 
 void BraveDOMWindowStorage::Trace(Visitor* visitor) const {
+  visitor->Trace(ephemeral_storage_namespaces_);
   visitor->Trace(ephemeral_session_storage_);
   visitor->Trace(ephemeral_local_storage_);
   Supplement<LocalDOMWindow>::Trace(visitor);