Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift Remove UA farbling on all platforms and unconditionally exclude Android model to 1.23.x #8600

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Uplift Remove UA farbling on all platforms and unconditionally exclude Android model to 1.23.x #8600

merged 2 commits into from
Apr 22, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Apr 21, 2021 •
edited by kjozwiak
Loading

Uplift of #8562 #8320
Resolves brave/brave-browser#15372
Resolves brave/brave-browser#15322
Resolves brave/brave-browser#15039
Resolved brave/brave-browser#14740

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@pilgrim-brave @yrliou
Merge pull request #8320 from brave/mpilgrim_ua_mobile
3dc3cb4 
Fix farbled user agent on mobile
@pilgrim-brave @yrliou
Merge pull request #8562 from brave/mpilgrim_remove_ua_farbling
d8d8077 
Remove UA farbling on all platforms and unconditionally exclude Android model
@yrliou yrliou added this to the 1.23.x - Release #2 milestone Apr 21, 2021
@yrliou yrliou requested a review from a team April 21, 2021 22:08
@yrliou yrliou self-assigned this Apr 21, 2021
@yrliou yrliou requested review from bridiver and a team as code owners April 21, 2021 22:08
@kjozwiak kjozwiak mentioned this pull request Apr 22, 2021
Closed
24 tasks
@kjozwiak
Copy link
Member

post-init failed due to a audit-deps warning as per https://ci.brave.com/job/pr-brave-browser-8562_1.23.x-post-init/1/execution/node/145/log/. However, this is a known issue and unrelated to this specific PR.

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-8562_1.23.x-linux/1/testReport/. However, these are known failures and unrelated to this specific PR.

linux / test-browser / BraveStatsUpdaterBrowserTest.StatsUpdaterMigration
linux / test-browser / BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference
linux / test-browser / BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode
linux / test-browser / BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode
linux / test-browser / BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference

kjozwiak
kjozwiak approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8562 (comment) & #8320 (comment).

@kjozwiak kjozwiak merged commit bf588e3 into 1.23.x Apr 22, 2021
@kjozwiak kjozwiak deleted the 8562_1.23.x branch April 22, 2021 08:11
kylehickinson pushed a commit that referenced this pull request Jan 22, 2024
@StephenHeaps
Fix #8600: Accounts Tab v2 (#8659)
6872792 
* Move Backup to `...` menu, and Add/Create Account specific for Accounts tab.

* Update `AccountsView` to v2 designs, create `AccountsStore` for building account cards with balances and price information.

* Create `AccountsStoreTests` unit test for fetching accounts and tokens with balance / total fiat for each account

* Card background using blockie material, refresh list on network change & show/hide test networks, small UI, tweaks

* Split `AssetIconView` into `AssetIcon` (no sizing) and `AssetIconView` (applies dynamic sizing). Split `NetworkIcon` into `NetworkIcon` (no sizing) and `NetworkIconView` (applies dynamic sizing).
Update `MultipleCircleIconView` to apply a background instead of just a stroke for when transparent icons are used.

* Add border to `...` icon in `MultipleCircleIconView` for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
1.23.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@yrliou @kjozwiak @pilgrim-brave