Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare endless looping due fingerprinting #15039

Closed
ryanbr opened this issue Mar 31, 2021 · 26 comments · Fixed by brave/brave-core#8562
Closed

Cloudflare endless looping due fingerprinting #15039

ryanbr opened this issue Mar 31, 2021 · 26 comments · Fixed by brave/brave-core#8562
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.

Comments

@ryanbr
Copy link

ryanbr commented Mar 31, 2021

Description

Visiting the http://chaingames.io/ caused an endless loop for the user

Steps to Reproduce

  1. Open http://chaingames.io/
  2. Expect Cloudflare to redirect
  3. (according to user, didn't redirect)

Actual result:

d5af81cb6b7c85b50a3cd68f1fbca3f65a763553_2_690x431

Expected result:

Allow cloudflare to work correct (redirect correctly, and not loop)

Reproduces how often:

I wasn't able to reproduce, was reported via the forums.

Brave version (brave://version info)

Version 1.22.70 Chromium: 89.0.4389.105 (Official Build) (x86_64)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes, (Fingerprinting)
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Reported here: https://community.brave.com/t/brave-browser-stuck-on-cloudflare-loop/224513/

I wasn't able to reproduce this, but logged ticket for followup/confirmation
5b1be1a02b2ee163a46b04675c2806c7e2f219c8
bcdf2ccb791afea13bb94f96e81f52a02722398f

@ryanbr ryanbr added webcompat/not-shields-related Sites are breaking because of something other than Shields. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields webcompat/shields Shields is breaking a website. OS/Desktop labels Mar 31, 2021
@ryanbr
Copy link
Author

ryanbr commented Mar 31, 2021

cc: @pes10k

@pes10k
Copy link
Contributor

pes10k commented Mar 31, 2021

I've reached out to CF to see if we can work things out with them. @ryanbr, could you follow up in the community thread and let them know that we're trying to work things out with Cloudflare?

@brave brave deleted a comment Mar 31, 2021
@ghost
Copy link

ghost commented Mar 31, 2021

strange behaviour cloudflare has. Notorious things they are upto. In brave we trust. fix the internet it will.

@pes10k pes10k self-assigned this Apr 2, 2021
@pes10k
Copy link
Contributor

pes10k commented Apr 2, 2021

Cloudflare says they've addressed, and I can't reproduce this anymore (I was on Wednesday). I'm going to close, though if anyone is still seeing this issue, please reopen and let me know. Thanks!

@pes10k pes10k closed this as completed Apr 2, 2021
@TAKEYE01
Copy link

TAKEYE01 commented Apr 3, 2021

Hello I am the person who reported this issue (Tannerk08) I want to thank you guys for resolving this problem. It now is fixed and works! Thank you guys for all the time you put in to make Brave better for the people!

@dimon222
Copy link

dimon222 commented Apr 5, 2021

Still happens on Android client.

@pes10k
Copy link
Contributor

pes10k commented Apr 5, 2021

thank you for letting me know @dimon222 , let me loop back with Cloudflare and see if they have any more information.

@pes10k
Copy link
Contributor

pes10k commented Apr 5, 2021

@dimon222 can you confirm whether you're using the default or aggressive level fingerprinting protections?

@dimon222
Copy link

dimon222 commented Apr 5, 2021

standard. Only if I put "Allow all fingerprints" the page is able to pass cloudflare's challenge.

@leoschet
Copy link

leoschet commented Apr 14, 2021

I still have this issue, same as dimon222, I only get throught by allowing all fingerprints. I'm using it on Mac v1.22.71

@pes10k
Copy link
Contributor

pes10k commented Apr 14, 2021

Thank you for the clarification @dimon222 and @leoschet , i will follow up with cloudflare again and see if I can get this sorted out. Than you again for reporting the issue and for your patience

@pes10k
Copy link
Contributor

pes10k commented Apr 14, 2021

@dimon222 and @leoschet , I was wondering if you each could let me know what UA string you're browsing with. Cloudflare has told me that would help them sort things out.

If you need a convenient place to get your UA, https://www.whatismybrowser.com/detect/what-is-my-user-agent can be handy

thanks for any help you can provide!

@dimon222
Copy link

@pes10k

Mozilla/5.0 (Linux; Android 11) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36

@bryanvaz
Copy link

I still have this issue, same as dimon222, I only get throught by allowing all fingerprints. I'm using it on Mac v1.22.71

Can confirm this. Happens across all Cloudflare DDoS protected sites, including Gitlab's signin page.

Allowing all fingerprinting (or of course shields down) allows the CF check to pass.

Cheers,
Bryan

@pes10k
Copy link
Contributor

pes10k commented Apr 19, 2021

Just to follow up here, I have an ongoing discussion with Cloudflare folks to sort this out. I hope to have more news to share shortly, but we're working on it aggressively

@tainium
Copy link

tainium commented Apr 21, 2021

Just another user reporting in. Having this issue on Linux client but disabling fingerprinting/shields doesn't fix it for me.

@pes10k
Copy link
Contributor

pes10k commented Apr 21, 2021

Just to update everyone on the issue, we were able to sort out the issue with Cloudflare (its a collision between Brave's fingerprinting defenses and changes in upstream), and its fixed in brave/brave-core#8562. It should hit nightly in the next 24 hours

There are also hot fixes being prepared for Beta and Stable too (see above), which should also land in the next 24 hours.

Thanks very much again for everyone's help in reporting this and making sure it got sorted!

@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 21, 2021
@pes10k pes10k added the OS/Android Fixes related to Android browser functionality label Apr 21, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Apr 22, 2021

Verified passed on

Brave | 1.23.73 Chromium: 90.0.4430.85 (Official Build) (x86_64)
-- | --
Revision | 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS | macOS Version 10.15.7 (Build 19H524)

Verified STR from description. Confirmed I was redirected as expected.

1 23 73


Verification passed on

Brave 1.23.73 Chromium: 90.0.4430.85 (Official Build) (64-bit)
Revision 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS Ubuntu 18.04 LTS

15039


Verification PASSED on Win 10 x64 using the following build:

Brave | 1.23.73 Chromium: 90.0.4430.85 (Official Build) (64-bit)
-- | --
Revision | 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS | Windows 10 OS Version 2009 (Build 19042.928)

image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.23.73 x64 build

  • Verified test plan from issue description
Android.ARM.Cloudflare.Redirect.mp4

Verification passed on Samsung Tab A with Android 10 running 1.23.73 x64 build

  • Verified test plan from issue description
Android.TAB.Cloudflare.Redirect.mp4

@kjkent
Copy link

kjkent commented May 9, 2022

Hi there,

I've been having issues with Brave Browser (1.38.111) on Linux (Fedora Workstation 35 & 36) not being able to pass DDOS protection pages including Cloudflare's. After completing the Cloudflare CAPTCHA, a long delay precedes a 403 error in DevTools.

This issue is not present using Brave on Windows, nor using Firefox on Linux.

@pes10k
Copy link
Contributor

pes10k commented May 11, 2022

@kjkent do you have fingerprinting settings at default or aggressive? Are you using a VPN or Tor mode or something similar that'd cause you to be visiting from a IP that might get differently classified by CF?

@srirambv, if you have a chance, could you see if you're able to recreate?

@kjkent
Copy link

kjkent commented May 13, 2022

@pes10k, I typically have fingerprinting at default, but the issue persists even when Brave Shields are down. I'm not running a VPN nor using Tor mode. I originally thought it might be due to me visiting from Linux instead of Windows but, after installing Firefox on Fedora, I was able to get through the DDOS check.

@pes10k
Copy link
Contributor

pes10k commented May 16, 2022 via email

@kjkent
Copy link

kjkent commented May 25, 2022

My apologies for the slow reply, @pes10k.

I'm connecting from the UK. I'd be happy to share the URLs I'm seeing the issue on, but it actually seems the issue has resolved. I recall that cloudflare.com itself inaccessible, but, I've just successfully accessed the website. In addition, a few minutes ago, https://sportsbikeshop.co.uk actually showed the DDOS protection screen for a second before redirecting successfully.

Good news from a practicality standpoint, but perhaps not for issue reproduction! I shall get in touch, though, if I see it again.

Thanks for your assistance with this.

@MichaelMichaelMichaelMichaelMichael

I have the same issue across all Cloudflare protected websites.
Using Version 1.44.112 Chromium: 106.0.5249.119 (Offizieller Build) (64-Bit)
Any advise on how to actually be able to visit those websites?

@pes10k
Copy link
Contributor

pes10k commented Oct 26, 2022

are you connecting through a VPN or Tor mode? Are you in default shields configurations? If the answers are no, no and yes, @ryanbr may be able to help debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

15 participants