Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UA farbling on all platforms and unconditionally exclude Android model #8562

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Apr 19, 2021

Resolves brave/brave-browser#15372
Resolves brave/brave-browser#15322
Resolves brave/brave-browser#15039

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add network UA tests back in always checking against the unfarbled UA

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_remove_ua_farbling branch from 3cc3345 to 880e03d Compare April 20, 2021 15:11
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_remove_ua_farbling branch from 880e03d to e18d30e Compare April 20, 2021 16:09
@pilgrim-brave
Copy link
Contributor Author

Added new DEPS file since review, as noted by gn_check

@pilgrim-brave pilgrim-brave merged commit 883a3d2 into master Apr 21, 2021
@pilgrim-brave pilgrim-brave deleted the mpilgrim_remove_ua_farbling branch April 21, 2021 00:00
@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 21, 2021
yrliou pushed a commit that referenced this pull request Apr 21, 2021
Remove UA farbling on all platforms and unconditionally exclude Android model
yrliou pushed a commit that referenced this pull request Apr 21, 2021
Remove UA farbling on all platforms and unconditionally exclude Android model
@kjozwiak
Copy link
Member

kjozwiak commented Apr 22, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.25.33 Chromium: 90.0.4430.85 (Official Build) nightly (64-bit)
-- | --
Revision | 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.25.31 Chromium: 90.0.4430.72

Test Case brave/brave-browser#15039

Went through the STR/Cases outlined via brave/brave-browser#15039 (comment) and ensured that Cloudflare correctly directed/opened http://chaingames.io.

Desktop Android
image Screenshot_20210421-223946_Brave - Nightly

Test Case brave/brave-browser#15322

1.22.71 Chromium: 89.0.4389.114 (Release) 1.25.31 Chromium: 90.0.4430.72
Screenshot_20210421-225257_Brave Screenshot_20210421-225530_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants