-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UA farbling on all platforms and unconditionally exclude Android model #8562
Conversation
browser/farbling/brave_navigator_useragent_farbling_browsertest.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add network UA tests back in always checking against the unfarbled UA
3cc3345
to
880e03d
Compare
880e03d
to
e18d30e
Compare
Added new DEPS file since review, as noted by gn_check |
Remove UA farbling on all platforms and unconditionally exclude Android model
Remove UA farbling on all platforms and unconditionally exclude Android model
Verification
Verification
Test Case brave/brave-browser#15039Went through the STR/Cases outlined via brave/brave-browser#15039 (comment) and ensured that Cloudflare correctly directed/opened http://chaingames.io.
Test Case brave/brave-browser#15322
|
Resolves brave/brave-browser#15372
Resolves brave/brave-browser#15322
Resolves brave/brave-browser#15039
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: