Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint uplift. #8298

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Pylint uplift. #8298

merged 1 commit into from
Mar 18, 2021

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Mar 18, 2021

Uplift of #8222

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik changed the base branch from master to 1.22.x March 18, 2021 20:46
@mihaiplesa mihaiplesa added the CI/skip Do not run CI builds (except noplatform) label Mar 18, 2021
@mihaiplesa mihaiplesa added this to the 1.22.x - Release milestone Mar 18, 2021
@mihaiplesa mihaiplesa requested review from a team and removed request for a team, bridiver, kylehickinson, tmancey, iefremov, simonhong and samartnik March 18, 2021 20:49
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android and removed CI/skip Do not run CI builds (except noplatform) labels Mar 18, 2021
@mihaiplesa mihaiplesa added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 18, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants