Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Updates shields button state on changing toolbar variations #8297

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Mar 18, 2021

Resolves brave/brave-browser#14645

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 18, 2021
@samartnik samartnik added this to the 1.24.x - Nightly milestone Mar 18, 2021
@samartnik samartnik self-assigned this Mar 18, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Mar 19, 2021

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.24.7 CR: 89.0.4389.90

Went through the STR/Cases via brave/brave-browser#14645 (comment) and ensured that the Brave Shields icon was enabled.


Verification passed on OnePlus 6T with Android 10 running 1.24.7 x64 nightly build

  • Verified shields doesn't look disabled when switching from custom tab to browser tab

mariospr added a commit that referenced this pull request Mar 22, 2021
Exclude browser tests from upstream that are known to fail in Brave
tmancey pushed a commit that referenced this pull request Oct 25, 2023
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Ref ##8297: Update brave-core to 1.60.113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in Browser causes shields to show up as disabled
3 participants