-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Updates shields button state on changing toolbar variations #8297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
Went through the STR/Cases via brave/brave-browser#14645 (comment) and ensured that the Brave Shields icon was enabled. Verification passed on OnePlus 6T with Android 10 running 1.24.7 x64 nightly build
|
Exclude browser tests from upstream that are known to fail in Brave
Co-authored-by: Jacob Sikorski <[email protected]>
Resolves brave/brave-browser#14645
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: