Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift Unstoppable Domains & ENS native support to 1.22.x #8291

Merged
merged 6 commits into from
Mar 19, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 18, 2021

Uplift of #7702 #8125 #8135 #8214 #8212 #8131
Original Issues:

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

yrliou and others added 6 commits March 18, 2021 10:33
Support Unstoppable Domains via DNS over HTTPS behind a feature flag
Do not show opt-in page for decentralized DNS support in OTR contexts
…l_ui

Fix decentralized dns interstitial css
Treat decentralized DNS servers as available before first probe is completed
Enable decentralized dns feature flag by default
@yrliou yrliou added this to the 1.22.x - Release milestone Mar 18, 2021
@yrliou yrliou self-assigned this Mar 18, 2021
@yrliou yrliou requested review from bridiver and a team as code owners March 18, 2021 18:00
@kjozwiak kjozwiak requested a review from a team March 18, 2021 19:49
@yrliou
Copy link
Member Author

yrliou commented Mar 18, 2021

pre-init failed with npm ERR! missing script: pylint-report
post-init failed with some unrelated audit-dep error
Otherwise CI looks good.

@kjozwiak
Copy link
Member

pre-init failed with npm ERR! missing script: pylint-report
post-init failed with some unrelated audit-dep error
Otherwise CI looks good.

Both unrelated as @yrliou mentioned above 👍

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly via the brave/brave-browser#14099 (comment), brave/brave-browser#14477 (comment), brave/brave-browser#14488 (comment), brave/brave-browser#14633 (comment), brave/brave-browser#14513 (comment).

@kjozwiak kjozwiak merged commit e104d7c into 1.22.x Mar 19, 2021
@kjozwiak kjozwiak deleted the uplift_UD_ENS_1.22.x branch March 19, 2021 02:28
bsclifton added a commit that referenced this pull request Mar 23, 2021
This reverts commit e104d7c, reversing
changes made to 5b3f345.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants