Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes vetted search engines detection #8011

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#14248

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to startpage.com. Make sure that your blocking shields are set to a standard mode
  2. Search for "iphone X"
  3. Make sure that you see Ads in a first couple results
    Screenshot from 2021-02-19 11-19-20
  4. Switch to aggressive mode in shields.
  5. Repeat the same search
  6. Make sure you don't see any ads results
    Screenshot from 2021-02-19 11-20-41

@SergeyZhukovsky SergeyZhukovsky merged commit 3ab79aa into master Feb 19, 2021
@SergeyZhukovsky SergeyZhukovsky deleted the vetted_engines_fix branch February 19, 2021 20:20
brave-builds pushed a commit that referenced this pull request Feb 19, 2021
@kjozwiak
Copy link
Member

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2009 (Build 19042.804)
Standard Aggressive
image image
image image

@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ using the following build:

Brave 1.22.39 Chromium: 89.0.4389.58

As per @SergeyZhukovsky, before the above fix we were blocking ads even though aggressive mode hasn't been implemented. @srirambv for this, we basically need to make sure that first party ads are being displayed.

Example Example
Screenshot_20210222-211241_Brave - Nightly Screenshot_20210222-211102_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosmetic filtering doesn't handle vetted search engines correctly if they have subdomains
3 participants