Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic filtering doesn't handle vetted search engines correctly if they have subdomains #14248

Closed
pes10k opened this issue Feb 19, 2021 · 5 comments · Fixed by brave/brave-core#8011

Comments

@pes10k
Copy link
Contributor

pes10k commented Feb 19, 2021

Currently we do not apply cosmetic filtering to privacy respecting ads on search partners in the default setting (we still hide then in the aggressive mode). However, the check for "is this a vetted search engine" page fails incorrectly for search engine subdomain pages.

For example, currently cosmetic filtering is default off for https://startpage.com/sp/search (this is expected). However, its default on for startpage subdomains (e.g., https://www.startpage.com/sp/search). The same is true for all the expected, vetted domains.

@SergeyZhukovsky
Copy link
Member

Created a follow up to cover that functionality with tests #14259

@LaurenWags
Copy link
Member

Labelling as QA/Blocked until uplift is completed

@kjozwiak
Copy link
Member

Removing QA/Blocked as this was uplifted via brave/brave-core#8014 👍

@LaurenWags
Copy link
Member

LaurenWags commented Feb 23, 2021

Verified passed with

Brave	1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (x86_64)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	macOS Version 10.15.7 (Build 19H512)

Verified test plan from brave/brave-core#8011 (comment) and brave/brave-core#8011 (comment) with different examples.

Example - Under Armour

Standard Aggressive
Standard-1 21 65-under armour Aggressive-1 21 65-under armour

Example - Windows

Standard Aggressive
Standard-1 21 65-windows Aggressive-1 21 65-windows

Verification passed on


Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified test plan from brave/brave-core#8011 (comment) and brave/brave-core#8011 (comment) with different examples.

Example - iphone X

Standard Aggressive
image image

Example - samsung tab

Standard Aggressive
image image

Verification passed on

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8011 (comment) and brave/brave-core#8011 (comment) with different examples.

Example - Samsung s21

Standard Aggressive
image image

Example - apple

Standard Aggressive
image image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.21.68 x64 build

  • Verified first part ads are listed when search for specific terms
  • Verified clicking on the ad loads a new tab that loads google.com result and then redirects to the first party page

Verification passed on Samsung Tab A with Android 10 running 1.21.68 x64 build

  • Verified first part ads are listed when search for specific terms
  • Verified clicking on the ad loads a new tab that loads google.com result and then redirects to the first party page
OnePlus 6T Samsung Tab A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment