Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page WebUI: restrict Together item to supported channel and region #7787

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

petemill
Copy link
Member

@petemill petemill commented Feb 2, 2021

Restricts brave/brave-browser#12776 to nightly channel (and regions which support Brave Together).
Resolves brave/brave-browser#13905

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • npm run storybook has a "together supported" toggle which can be used.
  • Otherwise, check the icon and tooltip aren't shown on non-nightly or development channel

@petemill petemill self-assigned this Feb 2, 2021
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton added this to the 1.21.x - Nightly milestone Feb 2, 2021
@bsclifton
Copy link
Member

Browser test has an unrelated failure on Windows for [ FAILED ] AdBlockServiceTest.CosmeticFilteringProtect1p (known issue; captured with brave/brave-browser#13887)

Good to merge 😄👍

@bsclifton bsclifton merged commit de980b4 into master Feb 2, 2021
@bsclifton bsclifton deleted the ntp-together-restrict branch February 2, 2021 23:12
kjozwiak added a commit that referenced this pull request Feb 3, 2021
Uplift #7787 to 1.20.x - New Tab Page WebUI: restrict Together item to supported channel and region
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Tab Page Brave Together link and prompt should only show on nightly
3 participants