Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AdBlockServiceTest.CosmeticFilteringProtect1p temporarily #13887

Closed
simonhong opened this issue Feb 2, 2021 · 2 comments · Fixed by brave/brave-core#7777
Closed

Disable AdBlockServiceTest.CosmeticFilteringProtect1p temporarily #13887

simonhong opened this issue Feb 2, 2021 · 2 comments · Fixed by brave/brave-core#7777

Comments

@simonhong
Copy link
Member

Will be enabled with fix for #13882

@bsclifton
Copy link
Member

@pes10k @simonhong @antonok-edm is this issue still applicable? Two PRs were created but both closed:

Not sure if there was a proper fix... I think this is Windows and only intermittent?

@pes10k
Copy link
Contributor

pes10k commented Feb 3, 2021

Sadly, its still needed. Im working on another approach that i hope will address the Windows issue.

Though when looking at this last night more, the worrying part is that Windows is doing the right thing, and the other platforms shouldn't be passing. Im really baffled, but hopefully my (incoming) rewrite with set things… re-right (har har)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment