Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Brave Together on New Tab Page #12776

Closed
bsclifton opened this issue Nov 18, 2020 · 12 comments · Fixed by brave/brave-core#7532 or brave/brave-core#7548
Closed

Add link to Brave Together on New Tab Page #12776

bsclifton opened this issue Nov 18, 2020 · 12 comments · Fixed by brave/brave-core#7532 or brave/brave-core#7548
Assignees
Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@bsclifton
Copy link
Member

bsclifton commented Nov 18, 2020

Description

On the NTP, there should be an icon for Brave Together
image

This could be highlighted when new by using a flyout (see picture)

Clicking the link would open https://together.brave.com/widget in the same tab

cc: @jamesmudgett @jsecretan for anything I'm missing

@jamesmudgett
Copy link

video-camera.svg.zip

@rebron rebron added features/P3A priority/P3 The next thing for us to work on. It'll ride the trains. and removed features/P3A labels Nov 23, 2020
@petemill
Copy link
Member

What are the rules for when the "flyout" appears? Or should it always appear until the user manually dismisses via the X icon?

@jsecretan
Copy link

Let's go with manual dismiss for now, thanks.

@petemill
Copy link
Member

No p3a for the button click?

@jsecretan
Copy link

I wouldn't worry about it right now, we will have some basic info on conferences started from the Brave Together page.

@petemill
Copy link
Member

petemill commented Dec 1, 2020

Where should Learn More link to? The same https://together.brave.com/widget URL? I take it not something like https://brave.com/privacy/browser/#brave-together...?

@jsecretan
Copy link

Hi @petemill let's just to go for https://www.brave.com/brave-together for now and I'll get it filled in before launch.

@petemill
Copy link
Member

petemill commented Jan 8, 2021

I merged brave/brave-core#7532 but now realizing that maybe we don't want it to point to https://www.brave.com/brave-together since it's no longer has a "Learn More" link but a "Try it now" button. @jsecretan what do you think?

I've made brave/brave-core#7548 which changes that button to point at the same https://together.brave.com/widget link. Let me know if you want to merge that, or an alternative.

@petemill petemill added this to the 1.20.x - Nightly milestone Jan 8, 2021
@jsecretan
Copy link

Ah yes, please @petemill, let's just change that to the widget link now. Thanks.

@LaurenWags
Copy link
Member

@petemill @jsecretan @rebron what should QA follow for a test plan for this? I didn't see one in the PR - should we make sure that it looks like the screens on the PR or is there more to it? Marking as QA/Blocked until this is sorted 👍🏻

@jsecretan
Copy link

Sorry for the delay @LaurenWags but this is only tied to Beta/Nightly now right @petemill ? If so, we can just do QA/No for now and revisit when we unmoor from nightly channels.

@LaurenWags
Copy link
Member

LaurenWags commented Feb 2, 2021

Removing QA/Blocked and relabeling as QA/No due to #13905 - please adjust if you disagree @rebron @bsclifton @kjozwiak

Also changing from release-notes/include to release-notes/exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
6 participants