-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab Page: Prompt for Brave Together #7532
Conversation
|
||
import styled from 'brave-ui/theme' | ||
|
||
const Button = styled('button')` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this is a new design system-able button style that we can make more shared when the design team iterates a bit more
@@ -186,6 +187,14 @@ export const newTabReducer: Reducer<NewTab.State | undefined> = (state: NewTab.S | |||
break | |||
} | |||
|
|||
case Actions.dismissTogetherPrompt.getType(): { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you are preferring not to add an exported constant to new_tab_types
. Do you want to eventually remove the need for that file completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes just trying to remove 1 layer of boilerplate. I've been using redux-act
for Brave Today on the NTP via today_actions.ts
and reducers/today
, so just continuing that here for anything new.
left: 0; | ||
right: 0; | ||
background: linear-gradient(305.95deg, #BF14A2 0%, #F73A1C 98.59%); | ||
clip-path: polygon( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
components/brave_new_tab_ui/components/default/footer/togetherTooltip/button.tsx
Outdated
Show resolved
Hide resolved
Targetable in css
Button in footer always shows Prompt (anchored to button) shows like a tooltip until the user manually closes via button.
0e2747e
to
d880de2
Compare
Rebased in order to try to fix CI sync errors. Also added a change to storybook in order to provide an option for right-to-left so that we can easily preview what the browser does on the NTP for certain languages. d880de2 |
Resolves brave/brave-browser#12776
Button Transitions
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: