-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Sync 1.18.x Uplift #7371
Merged
Merged
iOS Sync 1.18.x Uplift #7371
Commits on Dec 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4650b9c - Browse repository at this point
Copy the full SHA 4650b9cView commit details -
Fix signature of function callback.
Fixes brave/brave-browser#12997 Fix Linting for Android/Linux
Configuration menu - View commit details
-
Copy full SHA for 2382216 - Browse repository at this point
Copy the full SHA 2382216View commit details -
Fixing BrowserMetrics constantly creating new files taking up 4MB each.
Fixes the issue where some users are seeing 5GB worth of files!
Configuration menu - View commit details
-
Copy full SHA for a3edbc5 - Browse repository at this point
Copy the full SHA a3edbc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c339a7f - Browse repository at this point
Copy the full SHA c339a7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89633ba - Browse repository at this point
Copy the full SHA 89633baView commit details -
Configuration menu - View commit details
-
Copy full SHA for c126ef6 - Browse repository at this point
Copy the full SHA c126ef6View commit details -
Merge pull request #7313 from brave/maxk-fix-patches
Updated patches with `npm run update_patches`
Configuration menu - View commit details
-
Copy full SHA for fdf73a5 - Browse repository at this point
Copy the full SHA fdf73a5View commit details -
Merge pull request #7337 from brave/fix_gn_check
Fix gn_check error on iOS
Configuration menu - View commit details
-
Copy full SHA for e1bb8aa - Browse repository at this point
Copy the full SHA e1bb8aaView commit details
Commits on Dec 28, 2020
-
Component //brave/* ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:13:11: Include not allowed. ^----------------------------------------------------- It is not in any dependency of //brave/browser/sync:sync The include file is in the target(s): //chrome/browser:browser which should somehow be reachable. ___________________ ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:14:11: Include not allowed. ^------------------------------------------------- It is not in any dependency of //brave/browser/sync:sync The include file is in the target(s): //chrome/browser:browser which should somehow be reachable. ``` inherited from existing file in a target that already had check_includes = false fix brave/brave-browser#12976
Configuration menu - View commit details
-
Copy full SHA for 7d16500 - Browse repository at this point
Copy the full SHA 7d16500View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.