Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gn_check failed at brave_profile_sync_service_delegate.cc #12976

Closed
yrliou opened this issue Dec 1, 2020 · 0 comments · Fixed by brave/brave-core#7303
Closed

gn_check failed at brave_profile_sync_service_delegate.cc #12976

yrliou opened this issue Dec 1, 2020 · 0 comments · Fixed by brave/brave-core#7303
Assignees
@bridiver
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.20.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Dec 1, 2020 

gn check /Users/yrliou/brave/src/out/Component //brave/*
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:13:11: Include not allowed.
#include "chrome/browser/sync/device_info_sync_service_factory.h"
          ^-----------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:14:11: Include not allowed.
#include "chrome/browser/sync/profile_sync_service_factory.h"
          ^-------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
bridiver added a commit to brave/brave-core that referenced this issue Dec 1, 2020
@bridiver
```
33184ea 
Component //brave/*
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:13:11: Include not allowed.
          ^-----------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:14:11: Include not allowed.
          ^-------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
```
inherited from existing file in a target that already had check_includes = false
fix brave/brave-browser#12976
@bridiver bridiver mentioned this issue Dec 1, 2020
Merged
23 tasks
@bridiver bridiver added this to the 1.20.x - Nightly milestone Dec 2, 2020
@bridiver bridiver self-assigned this Dec 2, 2020
bsclifton pushed a commit to brave/brave-core that referenced this issue Dec 28, 2020
@bridiver @bsclifton
```
fb1da99 
Component //brave/*
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:13:11: Include not allowed.
          ^-----------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:14:11: Include not allowed.
          ^-------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
```
inherited from existing file in a target that already had check_includes = false
fix brave/brave-browser#12976
bsclifton pushed a commit to brave/brave-core that referenced this issue Dec 28, 2020
@bridiver @bsclifton
```
7d16500 
Component //brave/*
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:13:11: Include not allowed.
          ^-----------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:14:11: Include not allowed.
          ^-------------------------------------------------
It is not in any dependency of
  //brave/browser/sync:sync
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
```
inherited from existing file in a target that already had check_includes = false
fix brave/brave-browser#12976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging a pull request may close this issue.

fix check includes brave/brave-core
2 participants
@bridiver @yrliou