Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated patches with npm run update_patches #7313

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 2, 2020

Fixes brave/brave-browser#12998

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from bbondy December 2, 2020 16:27
@mkarolin mkarolin requested a review from a team as a code owner December 2, 2020 16:27
@mkarolin mkarolin self-assigned this Dec 2, 2020
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 2, 2020
@bbondy bbondy merged commit 6f661ec into master Dec 2, 2020
@bbondy bbondy deleted the maxk-fix-patches branch December 2, 2020 16:31
@mkarolin mkarolin added this to the 1.20.x - Nightly milestone Dec 2, 2020
Brandon-T added a commit that referenced this pull request Dec 14, 2020
Updated patches with `npm run update_patches`
Brandon-T added a commit that referenced this pull request Dec 18, 2020
Updated patches with `npm run update_patches`
Brandon-T added a commit that referenced this pull request Dec 18, 2020
Updated patches with `npm run update_patches`
bsclifton pushed a commit that referenced this pull request Dec 27, 2020
Updated patches with `npm run update_patches`
bsclifton pushed a commit that referenced this pull request Dec 27, 2020
Updated patches with `npm run update_patches`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A patch is failing to apply on Windows CI
2 participants