Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encoding related code #6228

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update encoding related code #6228

merged 1 commit into from
Jul 28, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves : brave/brave-browser#10945

Submitter Checklist:

Test Plan:

Follow the test plan from the issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 28, 2020
@deeppandya deeppandya added this to the 1.11.x - Release Hotfix 2 milestone Jul 28, 2020
@deeppandya deeppandya self-assigned this Jul 28, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya force-pushed the rate_brave_encoding_dp branch from 8ea9b88 to 63287d1 Compare July 28, 2020 18:43
@deeppandya deeppandya merged commit 86c219f into master Jul 28, 2020
@deeppandya deeppandya deleted the rate_brave_encoding_dp branch July 28, 2020 20:05
brave-builds pushed a commit that referenced this pull request Jul 28, 2020
brave-builds pushed a commit that referenced this pull request Jul 28, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 29, 2020

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.1.14.2.apk nightly build

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.14.2 Nightly BraveModernx86.apk

Verification passed on LG Nexus 5 (ARM) with Android 5.1 running 1.14.2 Nightly BraveModernarm.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Rate Brave does not send feedback on older Android devices - follow up to 8243
3 participants