Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encoding related code (uplift to 1.11.x) #6240

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

deeppandya
Copy link
Contributor

Uplift of #6228

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added this to the Android 1.11.x Release milestone Jul 28, 2020
@deeppandya deeppandya requested a review from a team July 28, 2020 20:19
@deeppandya deeppandya self-assigned this Jul 28, 2020
@kjozwiak
Copy link
Member

npm run audit_deps failed on each platform due to lodash which is a known intermittent issue. Issue was already fixed on the other channels. Doesn't block uplift.

Looks like the Linux instance was dropped/disconnected as per https://ci.brave.com/job/pr-brave-browser-rate_brave_encoding_dp_1.11.x/1/execution/node/470/log/. Restarting.

17:16:14  Cannot contact i-0b080b3ee06fa2255: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@17a0da77:i-0b080b3ee06fa2255": Remote call on i-0b080b3ee06fa2255 failed. The channel is closing down or has closed down
17:21:13  Could not connect to i-0b080b3ee06fa2255 to send interrupt signal to process

Looks like the Win x64 instance was also lost/disconnected as per https://ci.brave.com/job/pr-brave-browser-rate_brave_encoding_dp_1.11.x/1/execution/node/136/log/. Restarting.

17:13:48  Cannot contact i-04fad74348e603827: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@6dd56be5:i-04fad74348e603827": Remote call on i-04fad74348e603827 failed. The channel is closing down or has closed down
17:18:53  Could not connect to i-04fad74348e603827 to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 29, 2020
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.11.x approved after deliberating with @brave/uplift-approvers . CI failed due to test browser which is a known intermittent issue. Hence approving for uplift

@srirambv srirambv merged commit 67ac468 into 1.11.x Jul 30, 2020
@srirambv srirambv deleted the rate_brave_encoding_dp_1.11.x branch July 30, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants