Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update encoding related code (uplift to 1.13.x) #6238

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Update encoding related code (uplift to 1.13.x) #6238

merged 1 commit into from
Jul 30, 2020

Conversation

brave-builds
Copy link
Collaborator

Uplift of #6228

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team July 28, 2020 20:15
@brave-builds brave-builds self-assigned this Jul 28, 2020
@brave-builds brave-builds added this to the 1.13.x - Beta milestone Jul 28, 2020
@kjozwiak
Copy link
Member

Restarting Win as we lost the instance due to Agent was removed as per https://ci.brave.com/job/pr-brave-browser-pr6228_rate_brave_encoding_dp_1.13.x/1/execution/node/254/log/.

17:13:48  Cannot contact i-004e6f719af151f9e: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@6d22d580:i-004e6f719af151f9e": Remote call on i-004e6f719af151f9e failed. The channel is closing down or has closed down
17:18:53  Could not connect to i-004e6f719af151f9e to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-linux labels Jul 29, 2020
srirambv
srirambv approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.x approved after deliberating with @brave/uplift-approvers

@srirambv srirambv merged commit 8e6e70b into 1.13.x Jul 30, 2020
@srirambv srirambv deleted the pr6228_rate_brave_encoding_dp_1.13.x branch July 30, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @srirambv @brave-browser-releases