Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make what Transifex gives us more error tolerant #6024

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 7, 2020

Ran npm run pep8
Built to make sure it doesn't cause any problems with xtb update

Resolves brave/brave-browser#10309

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 1.12.x - Nightly milestone Jul 7, 2020
@bbondy bbondy requested a review from mkarolin July 7, 2020 20:22
@bbondy bbondy self-assigned this Jul 7, 2020
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

This is a common mistake that some but not all localizers make
since Transifex displays our source string files double escaped
@bbondy bbondy merged commit 21ee156 into master Jul 8, 2020
@bbondy bbondy deleted the l10n-transifex-fixups branch July 8, 2020 16:01
mkarolin pushed a commit that referenced this pull request Jul 8, 2020
Make what Transifex gives us more error tolerant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Upload to Transifex double escapes ampersands.
2 participants