Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave stats use wrong word for "saved" in German translation #10512

Closed
dhaun opened this issue Jun 29, 2020 · 1 comment
Closed

[Desktop] Brave stats use wrong word for "saved" in German translation #10512

dhaun opened this issue Jun 29, 2020 · 1 comment
Assignees
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@dhaun
Copy link

dhaun commented Jun 29, 2020

Description

tl;dr Brave uses the German word "gespeichert" for "saved" where it should instead use the German word "gespart".

The Brave statistics as displayed in a new window have a wrong translation for the word "saved" (as in so-and-so much times saved). That's because the English word can both mean "stored" (as in: saved to disk) and "held back" or "not used" (as in: saved time / bandwidth).

Steps to Reproduce

  1. Have the Brave stats switched on
  2. Have the Browser / system language set to German
  3. Open a new window

Actual result:

Says things like:

  • 88.6 MB Bandbreite gespeichert
  • 3 Minuten Zeit gespeichert

Expected result:

Should say:

  • 88.6 MB Bandbreite gespart
  • 3 Minuten Zeit gespart

Reproduces how often:

Every time

Brave version (brave://version info)

Version/Channel Information:

Brave 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.15.5 (Build 19F101)

This is the current version at the time of this writing. Haven't tried any beta, dev, or nightly builds.

Other Additional Information:

n/a

Miscellaneous Information:

wrong-german-translation-for-saved

n/a

@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 29, 2020
@mkarolin mkarolin self-assigned this Jul 15, 2020
@mkarolin mkarolin added this to the 1.11.x - Release milestone Jul 15, 2020
@mkarolin
Copy link
Contributor

Fixed by brave/brave-core#6024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants