Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher list improvements (uplift to 1.8.x) #5315

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 22, 2020

Uplift of #5301
Uplift of #5355
Uplift of #5356

Fixes brave/brave-browser#9376
Fixes brave/brave-browser#9440
Fixes brave/brave-browser#9441

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 22, 2020
@brave-builds brave-builds added this to the 1.8.x - Release milestone Apr 22, 2020
@NejcZdovc NejcZdovc removed their request for review April 22, 2020 15:54
@kjozwiak
Copy link
Member

Restarting Linux as it looks like the node was disconnected during dist as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.8.x/1/execution/node/438/log/.

13:05:31  Cannot contact linux-spot-4: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@5e78622a:linux-spot-4": Remote call on linux-spot-4 failed. The channel is closing down or has closed down
13:17:53  ninja: build stopped: interrupted by user.
13:22:59  wrapper script does not seem to be touching the log file in /home/ubuntu/jenkins/workspace/publisher-list-improvments_1.8.x@tmp/durable-b8e0af38
13:22:59  (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)

Restarting Win x64 as it looks like the node was disconnected as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.8.x/1/execution/node/279/log/.

13:16:17  Cannot contact i-0ccb4af2640cd81c4: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@6a3c188b:i-0ccb4af2640cd81c4": Remote call on i-0ccb4af2640cd81c4 failed. The channel is closing down or has closed down
13:21:09  Could not connect to i-0ccb4af2640cd81c4 to send interrupt signal to process

Looks like test-browser failed on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.8.x/1/execution/node/556/log/.

13:37:32  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6086 ms)
13:37:32  [539/539] BraveRewardsBrowserTest.NotVerifiedWallet (6336 ms)
13:37:32  1 test failed:
13:37:32      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2323)

The above is a known issue and will be addressed via brave/brave-browser#9339.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 22, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, bsclifton, kjozwiak, rebron and srirambv April 24, 2020 17:59
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 73f2a58 into 1.8.x Apr 24, 2020
@bsclifton bsclifton deleted the pr5301_publisher-list-improvments_1.8.x branch April 24, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants