Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizes publisher list timers #5356

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Optimizes publisher list timers #5356

merged 1 commit into from
Apr 24, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 24, 2020

Resolves brave/brave-browser#9441

Submitter Checklist:

Test Plan:

  • enable rewards
  • wait for publisher list to be downloaded (you can see it in the logs OnDowload)
  • disable rewards
  • wait for interval to expire again
  • make sure that download doesn't happen again
  • restart a browser and make sure that download doesn't happen
  • enable rewards
  • make sure that download starts

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone Apr 24, 2020
@NejcZdovc NejcZdovc requested a review from a team April 24, 2020 07:22
@NejcZdovc NejcZdovc self-assigned this Apr 24, 2020
@NejcZdovc NejcZdovc requested a review from bsclifton April 24, 2020 07:25
@NejcZdovc
Copy link
Contributor Author

CI failed on brave/brave-browser#9339, everything else is ok

@@ -45,7 +45,7 @@ class Publisher {
const std::string& publisher_key,
ledger::OnRefreshPublisherCallback callback);

void SetPublisherServerListTimer();
void SetPublisherServerListTimer(const bool rewards_enabled);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Chromium C++ style guide says:

For a function parameter passed by value, const has no effect on the caller, thus is not recommended in function declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize timers for publisher lists
3 participants