Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes insert query for social links #5355

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Fixes insert query for social links #5355

merged 1 commit into from
Apr 24, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 24, 2020

Resolves brave/brave-browser#9440

Submitter Checklist:

Test Plan:

  • start browser with dev env
  • enable rewards
  • make sure that there is no sqlite query error

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone Apr 24, 2020
@NejcZdovc NejcZdovc requested a review from a team April 24, 2020 06:16
@NejcZdovc NejcZdovc self-assigned this Apr 24, 2020
@NejcZdovc NejcZdovc added the CI/skip-ios Do not run CI builds for iOS label Apr 24, 2020

for (const auto& link : info.links) {
if (link.second.empty()) {
continue;
}

if (i == 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be only set when we have an actual record that we would insert

@NejcZdovc NejcZdovc requested a review from bsclifton April 24, 2020 06:58
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ++

@NejcZdovc
Copy link
Contributor Author

Ci failed on a known error

@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave | 1.10.9 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | macOS Version 10.15.3 (Build 19D76)

Launched Brave using the following and ensured there wasn't any SQLite DB errors:

/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --log-level=2 --enable-logging=stderr --rewards=development=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query is not correct if social links are empty
3 participants