-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes insert query for social links #5355
Conversation
|
||
for (const auto& link : info.links) { | ||
if (link.second.empty()) { | ||
continue; | ||
} | ||
|
||
if (i == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be only set when we have an actual record that we would insert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ++
Ci failed on a known error |
Verification PASSED on
Launched Brave using the following and ensured there wasn't any SQLite DB errors:
|
Resolves brave/brave-browser#9440
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.