Fixed contribution queue not being deleted (1.2.x)

[NejcZdovc]

Resolves brave/brave-browser#7579

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

covered with unit tests

plan for QA

• enable rewards
• claim grant
• close browser
• copy db from corrupted profile (ask @NejcZdovc for it) into current profile
• start the browser
• make sure that no contribution is made
• open db and make sure that contribution_queue and contribution_queue_publishers is empty

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[bsclifton]

++

[kjozwiak]

Verification PASSED on macOS 10.15.2 x64 & Windows 10 x64. Went through the following:

Went through the STR outlined via #4303 (comment) and reproduced the issue using 1.1.23 Chromium: 79.0.3945.88. Once the publisher_info_db was replaced with the one that @NejcZdovc provided, the a-c automatically launched and the grant was drained from the account. Once the a-c went through, Rewards kept trying to contribute as per the following:

[9645:775:0103/142308.479053:WARNING:contribution.cc(683)] You do not have enough funds for auto contribution
[9640:115379:0103/142308.479373:ERROR:database.cc(1584)] publisher_info_db sqlite error 1, errno 0: no such table: main.publisher_info_old, sql: DELETE FROM contribution_queue WHERE contribution_queue_id = ?

Using the 1.2.40 Chromium: 79.0.3945.88 (PR build that includes the fix), that the a-c didn't occur once the build was relaunched and that both contribution_queue and contribution_queue_publishers were empty. Left Brave sitting there for ~10min and didn't see any errors regarding Brave trying to auto-contribute.

• Reproduced the issue on 1.1.23 CR: 79.0.3945.88 using the steps from description and the DB provided by @NejcZdovc. Confirmed that AC occurred and kept attempting to contribute after wallet was drained (saw messages in logs from above). Upgraded this profile to the PR build for this issue and confirmed that no additional attempts to contribute occurred and logs did not show previous messages. Additionally, confirmed in the db that contribution_queue and contribution_queue_publishers were empty.

Also went through the upgrade cases that @LaurenWags mentioned ☝️ on Windows 10 x64 without any issues.

Verification PASSED with macOS 10.14.6 x64

• Reproduced the issue on 1.1.23 CR: 79.0.3945.88 using the steps from description and the DB provided by @NejcZdovc. Confirmed that AC occurred and kept attempting to contribute after wallet was drained (saw messages in logs from above). Upgraded this profile to the PR build for this issue and confirmed that no additional attempts to contribute occurred and logs did not show previous messages. Additionally, confirmed in the db that contribution_queue and contribution_queue_publishers were empty.
• Also, verified on a clean profile using the test plan from Fixed contribution queue not being deleted (1.2.x) #4303 (comment). Confirmed that no auto contribute occurred and contribution_queue and contribution_queue_publishers were empty in the db.

[kjozwiak]

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

[bsclifton]

@NejcZdovc don't forget to down-drop (opposite of uplift?) this to 1.3 also 😄 And then I'm not sure if a refactor issue was created for Dev/Nightly regarding a solution which would be allowed to make schema changes

[NejcZdovc]

@bsclifton 1.3 PR created #4307 and issue for 1.4 brave/brave-browser#7593