Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete contribution queue items #7593

Closed
NejcZdovc opened this issue Jan 4, 2020 · 0 comments · Fixed by brave/brave-core#5680
Closed

Do not delete contribution queue items #7593

NejcZdovc opened this issue Jan 4, 2020 · 0 comments · Fixed by brave/brave-core#5680
Assignees
@emerick
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.11.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 4, 2020 •
edited
Loading

We landed this issue/fix #7579. This was temporary fix. The real solution is implement timestamp (completed_at) into contribution_queue. This way we don't need to delete any records and it's safer. GetFirstContributionQueue should now fetch first item from the queue that completed_at is null.
@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Blocked labels Jan 4, 2020
@NejcZdovc NejcZdovc added this to the 1.4.x - Dev milestone Jan 4, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 4, 2020
@NejcZdovc NejcZdovc mentioned this issue Jan 4, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc changed the title Contribution queue is not cleared (1.4 and 1.5) Contribution queue is not cleared (1.4.x and down) Jan 4, 2020
@NejcZdovc NejcZdovc mentioned this issue Jan 9, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added the QA/No label Jan 9, 2020
@NejcZdovc NejcZdovc changed the title Contribution queue is not cleared (1.4.x and down) Do not delete contribution queue items Jan 10, 2020
@NejcZdovc NejcZdovc removed this from the 1.4.x - Dev milestone Jan 10, 2020
@NejcZdovc NejcZdovc modified the milestone: 1.5.x - Nightly Jan 10, 2020
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jan 10, 2020
@NejcZdovc NejcZdovc removed their assignment Jan 10, 2020
@emerick emerick mentioned this issue May 28, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Do not delete contribution queue items brave/brave-core
2 participants
@emerick @NejcZdovc