Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed contribution queue not being deleted (1.5.x) #4347

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 9, 2020

Resolves brave/brave-browser#7579

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.5.x - Nightly milestone Jan 9, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 9, 2020
@NejcZdovc NejcZdovc force-pushed the contribution-queue-1.5 branch 2 times, most recently from 2d61591 to d9fde44 Compare January 9, 2020 18:33
@NejcZdovc NejcZdovc force-pushed the contribution-queue-1.5 branch from d9fde44 to da2a7cf Compare January 9, 2020 23:48
@NejcZdovc NejcZdovc changed the title Fixes contribution queue Fixed contribution queue not being deleted (1.5.x) Jan 9, 2020
@NejcZdovc NejcZdovc requested a review from a team January 9, 2020 23:48
@NejcZdovc NejcZdovc marked this pull request as ready for review January 9, 2020 23:48
@NejcZdovc NejcZdovc requested review from a team and bsclifton and removed request for a team January 9, 2020 23:49
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is same as what was done w/ 1.2

Has already been reviewed/approved there. Approving 👍

@NejcZdovc
Copy link
Contributor Author

C( failed on test-install, not related to this PR

@NejcZdovc NejcZdovc merged commit e3383be into master Jan 10, 2020
@NejcZdovc NejcZdovc deleted the contribution-queue-1.5 branch January 10, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution queue is not cleared
2 participants