Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed contribution queue not being deleted (1.3.x) #4307

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

NejcZdovc
Copy link
Contributor

Resolves brave/brave-browser#7579

Submitter Checklist:

Test Plan:

covered with unit tests

plan for QA

  • enable rewards
  • claim grant
  • close browser
  • copy db from corrupted profile (ask @NejcZdovc for it) into current profile
  • start the browser
  • make sure that no contribution is made
  • open db and make sure that contribution_queue and contribution_queue_publishers is empty

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.3.x - Beta milestone Jan 4, 2020
@NejcZdovc NejcZdovc requested a review from a team January 4, 2020 06:26
@NejcZdovc NejcZdovc self-assigned this Jan 4, 2020
@NejcZdovc NejcZdovc changed the title Fixed contribution queue not being deleted Fixed contribution queue not being deleted (1.3.x) Jan 4, 2020
@NejcZdovc
Copy link
Contributor Author

CI failed on audit-network and test-install. All known and not related to this PR.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging; deliberation had already taken place (see #4303 (comment)) and was previously approved 😄👍

@bsclifton bsclifton merged commit ed68550 into 1.3.x Jan 6, 2020
@bsclifton bsclifton deleted the contribution-queue-1.3 branch January 6, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants