Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist allowed URL patterns from system network context #406

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 6, 2018

Fix brave/brave-browser#163

Let me know what you think about this work in progress. If we can find a way around the TODO comment on the bottom, then we can change to a DCHECK. I think logging is better than nothing for now though.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy
Copy link
Member Author

bbondy commented Sep 6, 2018

If anyone wants to pick this up from here from me, feel free.
I'm purposely not canceling the URLs, but just causing debug assertions, I think that's the right first step towards this.

Please just use my branch ledger-urls and work on top of it.

@diracdeltas
Copy link
Member

++ i like this approach

@bbondy
Copy link
Member Author

bbondy commented Sep 10, 2018

Going ahead with merging this per a DM discussion with @diracdeltas and @jumde.

Work for being more aggressive about this check is added in an issue here:
brave/brave-browser#1090

@bbondy bbondy changed the title WIP: Whitelist allowed URL patterns from system network context Whitelist allowed URL patterns from system network context Sep 10, 2018
@bbondy bbondy merged commit bb2666a into master Sep 10, 2018
@bbondy bbondy self-assigned this Sep 12, 2018
@bsclifton bsclifton deleted the ledger-urls branch September 26, 2018 05:44
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
cezaraugusto pushed a commit that referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist origins accessed from main processes
2 participants