Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCHECK allowed URL patterns from system network context #1090

Closed
bbondy opened this issue Sep 10, 2018 · 0 comments · Fixed by brave/brave-core#557
Closed

DCHECK allowed URL patterns from system network context #1090

bbondy opened this issue Sep 10, 2018 · 0 comments · Fixed by brave/brave-core#557
Labels
closed/wontfix priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. privacy security

Comments

@bbondy
Copy link
Member

bbondy commented Sep 10, 2018

brave/brave-core#406 added a log only message when there are unknown URL patterns accessed. This task is to make it more strict.
@bbondy bbondy added this to the 1.x Backlog milestone Sep 10, 2018
@bbondy bbondy mentioned this issue Sep 10, 2018
Merged
11 tasks
@diracdeltas diracdeltas modified the milestones: 1.x Backlog, 1.0 (0.56.x) Oct 2, 2018
@diracdeltas diracdeltas added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 2, 2018
@pilgrim-brave pilgrim-brave mentioned this issue Oct 3, 2018
Merged
11 tasks
@bbondy bbondy modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 3, 2018
@bbondy bbondy reopened this Oct 3, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 (0.56.x) Oct 3, 2018
@bbondy bbondy reopened this Oct 3, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@diracdeltas diracdeltas added the privacy/connect This requires making a network connection to a third-party service. label Oct 31, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 23, 2019
This was referenced Dec 2, 2021
Closed
Closed
Closed
Closed
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P3 Backlog in General May 28, 2024
@bbondy bbondy closed this as completed Jul 2, 2024
@github-project-automation github-project-automation bot moved this from P3 Backlog to Completed in General Jul 2, 2024
@rebron rebron removed this from General Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. privacy security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finalize outstanding checks and turn on DCHECK for disallowed URLs
5 participants
@fmarier @diracdeltas @tildelowengrimm @bbondy @rebron