-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable the post uninstall survey on Windows #18063
Labels
OS/Desktop
OS/Windows
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
24 tasks
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Sep 16, 2021
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Sep 16, 2021
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Dec 1, 2021
This was referenced Dec 1, 2021
7 tasks
Verification PASSED via the following verifications:
|
Brave | 1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit) |
---|---|
Revision | 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090} |
OS | Windows 11 Version 21H2 (Build 22000.348) |
- ensured that uninstalling Brave opens https://brave.com/uninstall-survey within
Edge
if Brave was already set as your default - ensured that uninstalling Brave opens https://brave.com/uninstall-survey within
Edge
if another browser is set as default - ensured the survey is launched when
Also delete your browsing data?
hasn't been selected/checked off before uninstalling - ensured the survey is launched when
Also delete your browsing data?
has been selected/checked off before uninstalling - also verified that when set as an
ms-edge
protocol handler, upon uninstallation, Windows popups up a "choose which app you'd like to open [the uninstall survey] with" dialog
Test Case #1 - Win 10
Brave | 1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit) |
---|---|
Revision | 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090} |
OS | Windows 10 Version 20H2 (Build 19042.1348) |
- ensured that uninstalling Brave opens https://brave.com/uninstall-survey within
Edge
if Brave was already set as your default - ensured that uninstalling Brave opens https://brave.com/uninstall-survey within
Edge
if another browser is set as default - ensured the survey is launched when
Also delete your browsing data?
hasn't been selected/checked off before uninstalling - ensured the survey is launched when
Also delete your browsing data?
has been selected/checked off before uninstalling - also verified that when set as an
ms-edge
protocol handler, upon uninstallation, Windows popups up a "choose which app you'd like to open [the uninstall survey] with" dialog
Test Case #1 - Win 8.1
Brave | 1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit) |
---|---|
Revision | 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090} |
OS | Windows 8.1 (Build 9600.20174) |
- ensured that uninstalling Brave opens https://brave.com/uninstall-survey within
Edge
if Brave was already set as your default - ensured that uninstalling Brave opens https://brave.com/uninstall-survey within
Edge
if another browser is set as default - ensured the survey is launched when
Also delete your browsing data?
hasn't been selected/checked off before uninstalling - ensured the survey is launched when
Also delete your browsing data?
has been selected/checked off before uninstalling - also verified that when set as an
ms-edge
protocol handler, upon uninstallation, Windows popups up a "choose which app you'd like to open [the uninstall survey] with" dialog
@stephendonner thanks for running through the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OS/Desktop
OS/Windows
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Test plan
See brave/brave-core#10078
Description
Originally removed with brave/brave-core#224
We would like to show a survey to users on Windows who do an uninstall. It would work the same as the Chromium one - opening in MS Edge after uninstall is complete
The text was updated successfully, but these errors were encountered: