Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the post uninstall survey on Windows #18063

Closed
bsclifton opened this issue Sep 13, 2021 · 2 comments · Fixed by brave/brave-core#10078
Closed

Re-enable the post uninstall survey on Windows #18063

bsclifton opened this issue Sep 13, 2021 · 2 comments · Fixed by brave/brave-core#10078

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 13, 2021

Test plan

See brave/brave-core#10078

Description

Originally removed with brave/brave-core#224

We would like to show a survey to users on Windows who do an uninstall. It would work the same as the Chromium one - opening in MS Edge after uninstall is complete

@stephendonner
Copy link

stephendonner commented Dec 8, 2021

Verification PASSED via the following verifications:

Uninstall Brave

Test Case #1 - Win 11

Brave 1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Windows 11 Version 21H2 (Build 22000.348)
  • ensured that uninstalling Brave opens https://brave.com/uninstall-survey within Edge if Brave was already set as your default
  • ensured that uninstalling Brave opens https://brave.com/uninstall-survey within Edge if another browser is set as default
  • ensured the survey is launched when Also delete your browsing data? hasn't been selected/checked off before uninstalling
  • ensured the survey is launched when Also delete your browsing data? has been selected/checked off before uninstalling
  • also verified that when set as an ms-edge protocol handler, upon uninstallation, Windows popups up a "choose which app you'd like to open [the uninstall survey] with" dialog

Test Case #1 - Win 10

Brave 1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Windows 10 Version 20H2 (Build 19042.1348)
  • ensured that uninstalling Brave opens https://brave.com/uninstall-survey within Edge if Brave was already set as your default
  • ensured that uninstalling Brave opens https://brave.com/uninstall-survey within Edge if another browser is set as default
  • ensured the survey is launched when Also delete your browsing data? hasn't been selected/checked off before uninstalling
  • ensured the survey is launched when Also delete your browsing data? has been selected/checked off before uninstalling
  • also verified that when set as an ms-edge protocol handler, upon uninstallation, Windows popups up a "choose which app you'd like to open [the uninstall survey] with" dialog

Test Case #1 - Win 8.1

Brave 1.33.100 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Windows 8.1 (Build 9600.20174)
  • ensured that uninstalling Brave opens https://brave.com/uninstall-survey within Edge if Brave was already set as your default
  • ensured that uninstalling Brave opens https://brave.com/uninstall-survey within Edge if another browser is set as default
  • ensured the survey is launched when Also delete your browsing data? hasn't been selected/checked off before uninstalling
  • ensured the survey is launched when Also delete your browsing data? has been selected/checked off before uninstalling
  • also verified that when set as an ms-edge protocol handler, upon uninstallation, Windows popups up a "choose which app you'd like to open [the uninstall survey] with" dialog

@kjozwiak
Copy link
Member

kjozwiak commented Dec 8, 2021

@stephendonner thanks for running through the Win 11 x64 & Win 10 x64 cases 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants