Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL not allowed from system network delegate: https://update.googleapis.com/service/update2/json #3021

Closed
fmarier opened this issue Jan 19, 2019 · 3 comments
Assignees

Comments

@fmarier
Copy link
Member

fmarier commented Jan 19, 2019

https://update.googleapis.com/service/update2 was added to the system network whitelist in brave/brave-core#406 in order to fix #163.

However, I see messages like this on my terminal though when I run master:

ERROR:brave_static_redirect_network_delegate_helper.cc(79)] URL not allowed from system network delegate: https://update.googleapis.com/service/update2/json

https://update.googleapis.com/service/update2/json is one of the two component updater endpoints defined in https://cs.chromium.org/chromium/src/components/component_updater/component_updater_url_constants.cc?rcl=85a8aae0b6208c2a76d1a6e6c0c617070d5df010 though it's missing from our whitelist.

I assume we should either whitelist both of them (assuming this is required for non-supported extensions from the Chrome store) or neither.

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@rebron
Copy link
Collaborator

rebron commented Feb 15, 2019

cc: @jumde is this fixed with the proxy pr? If so, can we close this one.

@jumde
Copy link
Contributor

jumde commented Feb 15, 2019

@rebron - This should be fixed by the changes made in go-updater. The changes have not yet been pushed to production yet, will keep it assigned to myself and test it again when the changes land in production.

@jumde jumde self-assigned this Feb 15, 2019
@fmarier
Copy link
Member Author

fmarier commented Mar 28, 2023

I can't reproduce this anymore and so I'll assume it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants