Fixes text for wallet verification (uplift to 0.70.x) #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
|
Restarting as this is due to the AWS spot fleet plugin as per: via |
hashmi-waseem
pushed a commit
to hashmi-waseem/brave-core
that referenced
this pull request
May 6, 2024
… to 0.61.x) (brave#1742) * Test network request in Tor profile with broken tor config. Should fail, but currently this is broken (brave#3058, brave#3349). * Block all external URL requests if tor is not set up right. Allow chrome, chrome-extension, and chrome-devtools URLs. This way we don't have to rely on other logic to prevent usage of the Tor profile before the daemon is configured, which turned out not be as reliable as hoped. fix brave#3058 fix brave#3349 * Appease lint and avoid C++ pitfalls. - Fix copyright headings to appease lint. - Fix header include guards to appease lint. - Fix missing includes. - Use explicit for unary constructors. - Fix whitespace to appease lint.
hashmi-waseem
pushed a commit
to hashmi-waseem/brave-core
that referenced
this pull request
May 6, 2024
… to 0.62.x) (brave#1741) * Test network request in Tor profile with broken tor config. Should fail, but currently this is broken (brave#3058, brave#3349). * Block all external URL requests if tor is not set up right. Allow chrome, chrome-extension, and chrome-devtools URLs. This way we don't have to rely on other logic to prevent usage of the Tor profile before the daemon is configured, which turned out not be as reliable as hoped. fix brave#3058 fix brave#3349 * Appease lint and avoid C++ pitfalls. - Fix copyright headings to appease lint. - Fix header include guards to appease lint. - Fix missing includes. - Use explicit for unary constructors. - Fix whitespace to appease lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #3333
Fixes brave/brave-browser#5875
Approved, please ensure that before merging:
After you merge: