Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes text for wallet verification #3333

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Fixes text for wallet verification #3333

merged 1 commit into from
Sep 4, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 4, 2019

Resolves brave/brave-browser#5875

Submitter Checklist:

Test Plan:

  • enable rewards
  • connect to Uphold with verified account
  • go to panel/settings page and make sure that verified button has correct text (Wallet Verified)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Sep 4, 2019
@NejcZdovc NejcZdovc requested a review from a team September 4, 2019 07:32
@NejcZdovc NejcZdovc self-assigned this Sep 4, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to change 'Verified' to 'Wallet Verified' for kyc'd user
3 participants