Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block URL requests in Tor windows if Tor is not set up right. (uplift to 0.62.x) #1741

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Block URL requests in Tor windows if Tor is not set up right. (uplift to 0.62.x) #1741

merged 3 commits into from
Feb 26, 2019

Conversation

riastradh-brave
Copy link
Contributor

Uplift of #1679

@riastradh-brave
Test network request in Tor profile with broken tor config.
b7cde3d 
Should fail, but currently this is broken (#3058, #3349).
@riastradh-brave
Block all external URL requests if tor is not set up right.
28ca125 
Allow chrome, chrome-extension, and chrome-devtools URLs.

This way we don't have to rely on other logic to prevent usage of the
Tor profile before the daemon is configured, which turned out not be
as reliable as hoped.

fix #3058
fix #3349
@riastradh-brave
Appease lint and avoid C++ pitfalls.
4c176bf 
- Fix copyright headings to appease lint.
- Fix header include guards to appease lint.
- Fix missing includes.
- Use explicit for unary constructors.
- Fix whitespace to appease lint.
@riastradh-brave riastradh-brave self-assigned this Feb 20, 2019
@riastradh-brave riastradh-brave added this to the 0.62.x - Dev milestone Feb 20, 2019
@riastradh-brave riastradh-brave changed the title (uplift to 0.62.x) Block URL requests in Tor windows if Tor is not set up right. (uplift to 0.62.x) Feb 20, 2019
bsclifton
bsclifton approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @kjozwiak @rebron - definitely want this in 0.62.x 😄 Fix looks nice and isolated and includes test. Huge ++ from me

@bsclifton bsclifton merged commit d12e67b into 0.62.x Feb 26, 2019
@bsclifton bsclifton deleted the 0.62.x_pr1679_riastradh-3349-blockiftorhosed branch February 26, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@riastradh-brave riastradh-brave

Labels
None yet
Projects
None yet
Milestone
0.62.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@riastradh-brave @bsclifton