Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift "Disable translate pref in Tor profile" to 0.69.x #3238

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Aug 22, 2019

Original Issue: brave/brave-browser#5657
PR: #3236

@yrliou yrliou added this to the 0.69.x - Beta milestone Aug 22, 2019
@kjozwiak
Copy link
Member

@yrliou when requesting uplift into either dev, beta or release, you'll need to add https://github.com/orgs/brave/teams/uplift-approvers into the reviewers as you'll need an approval from one of those individuals on the team 👍

@yrliou yrliou requested a review from a team August 22, 2019 15:35
@yrliou yrliou self-assigned this Aug 22, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yrliou! Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins & CI/Travis passed without any errors or failures. Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.

@yrliou yrliou merged commit 43b80eb into 0.69.x Aug 22, 2019
@yrliou yrliou deleted the disable_translate_pref_in_tor_0.69.x branch August 22, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants