Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable translate pref in Tor profile. #3236

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Aug 22, 2019

Fix brave/brave-browser#5657
This would prevent showing the translate bubble in Tor mode which we currently ask users if they want to install google translate extension to translate the page.

Submitter Checklist:

Test Plan:

  1. Make sure google translate extension is not installed.
  2. Open tor window and visit https://www.deutschland.de/de, should not show any prompt for asking if users would like to install google translate extension.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.71.x - Nightly milestone Aug 22, 2019
@yrliou yrliou self-assigned this Aug 22, 2019
@yrliou yrliou requested review from darkdh, bbondy and emerick August 22, 2019 01:58
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yrliou yrliou merged commit bc748c5 into master Aug 22, 2019
@yrliou yrliou deleted the disable_translate_pref_in_tor branch August 22, 2019 04:30
yrliou added a commit that referenced this pull request Aug 22, 2019
yrliou added a commit that referenced this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "translate this page" popup in Tor mode too
3 participants