Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "translate this page" popup in Tor mode too #5657

Closed
rulatir opened this issue Aug 14, 2019 · 5 comments · Fixed by brave/brave-core#3236
Closed

Disable "translate this page" popup in Tor mode too #5657

rulatir opened this issue Aug 14, 2019 · 5 comments · Fixed by brave/brave-core#3236

Comments

@rulatir
Copy link

rulatir commented Aug 14, 2019

I unchecked "Offer to translate pages in this language" (note: this is a back-translation of the UI string from Polish, the English original may be slightly different) for every content language added in settings.

I have also disabled the global setting, "Offer to translate pages in foreign languages" (also backtranslated).

These settings are ignored in Tor mode. The request is simple: make them NOT ignored in Tor mode. The "Install Google Translate extension to translate this page?" popup is a persistent annoyance.

@bsclifton
Copy link
Member

cc: @yrliou

@yrliou
Copy link
Member

yrliou commented Aug 22, 2019

Since right now we don't support extensions in Tor and we don't support setting this pref in Tor through settings page either, I think we should make this pref to be false in Tor automatically so we won't prompt users in Tor windows when they visited a page not in their language.

@yrliou
Copy link
Member

yrliou commented Aug 22, 2019

cc @rebron per ^^

@Jamscare
Copy link

It's hard to get in, I don't understand.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 25, 2019

Verification passed on

Brave 0.69.115 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment