Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page: fix DCHECK #2835

Merged
merged 1 commit into from
Jul 1, 2019
Merged

New Tab Page: fix DCHECK #2835

merged 1 commit into from
Jul 1, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Jul 1, 2019

Check IsSafeToSetWebUIProperties() inside a call from WebContentsObserver::RenderViewReady
Fix brave/brave-browser#5086

Follow-up from #2831

Submitter Checklist:

Test Plan:

Follow test plan from brave/brave-browser#5086

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Check `IsSafeToSetWebUIProperties()` inside a call from `WebContentsObserver::RenderViewReady`
Fix brave/brave-browser#5086
@petemill petemill requested review from bsclifton and emerick July 1, 2019 16:46
@petemill petemill self-assigned this Jul 1, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petemill petemill merged commit 8e18821 into master Jul 1, 2019
@petemill petemill deleted the fix/5086-new-tab-dcheck branch July 1, 2019 17:22
@petemill petemill added this to the 0.69.x - Nightly milestone Jul 1, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCHECK failed in new_tab_ui
3 participants