New Tab Page WebUI: Use Profile Preferences to store page options instead of localStorage (uplift to 0.68.x) #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
|
Verified this on Nightly - however, @emerick reported a DCHECK error which is likely related to this. Going to check that out... |
|
Updated to include DCHECK fix 😄👍 |
New Tab Page: fix DCHECK
bsclifton
force-pushed
the
pr2831_ntp-pref-store_0.68.x
branch
from
5536ae0 to
669c4c2
Compare
bsclifton
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
This has been in nightly and has been working great! CI has problems when running lint- Jenkins encounters an error and skips the actual build steps. I'm fairly certain this is not related to the work here. Going to merge and (worst case) we can revert if issues are encountered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #2831 and #2835
Fix brave/brave-browser#5064
Fix brave/brave-browser#2848
Approved, please ensure that before merging:
After you merge: