New Tab Page WebUI: Use Profile Preferences to store page options instead of localStorage #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
simonhong
reviewed
Jun 28, 2019
| public: | ||
| explicit BraveNewTabMessageHandler(BraveNewTabUI* web_ui); | ||
| ~BraveNewTabMessageHandler() override; | ||
| void OnStatsChanged(); |
There was a problem hiding this comment.
nit: These three callback methods can be in private section.
There was a problem hiding this comment.
Thanks for spotting, this is fixed now. It was left over from a previous strategy.
bsclifton
previously approved these changes
Jun 28, 2019
There was a problem hiding this comment.
Code looks great (see nits by @simonhong) - I verified the functionality works as expected and even cracked open the Default/Preferences file to verify the new setting by hand
Really nice work on this one! 😻
|
There is a browser test failure here: |
bsclifton
reviewed
Jun 28, 2019
imptrx
reviewed
Jun 28, 2019
… MessageHandler Following best practices from chromium webui documentation, move towards using DataSource keys for the initial page data, and FireWebUIListener for updating data. We're still manually setting data on the render_host in the WebUIController, but this refactor allows us to use FireWebUIListener now, and move towards using DataSource for that data in the future. MessageHandler allows us to use an established JS lifecycle to ensure that data is only sent to the correct contexts at the correct time. Use FireWebUIListener for 'stats-updated' instead of expecting a global 'statsUpdated' function to exist (which was causing some JS errors).
…tead of localStorage This allows: - Surfacing these preferences outside of the NTP - Syncing / migrating the preferences - Making the change immediately for all open NTP Use FireWebUIListener to push data to javascript event subscribers. Still uses render_view_host->SetWebUIProperty (like the existing NTP data), which we may port in the future to a DataSource Dictionary like the other WebUI in chromium. Provides any data retreived or updated to redux store via redux action, but does not use redux actions to ask for a data change. Fix brave/brave-browser#5064
|
I guess this also fixes brave/brave-browser#2848 since the static global function call |
brave-builds
pushed a commit
that referenced
this pull request
Jun 29, 2019
4 tasks
This was referenced Jul 1, 2019
bsclifton
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow-up is required along with this PR:
Fix brave/brave-browser#5064
Fix brave/brave-browser#2848
This is created as a PR on top of master and does not include the extra preferences from #2762 since it has not been merged yet.
This allows:
Use FireWebUIListener to push data to javascript event subscribers.
Still uses render_view_host->SetWebUIProperty (like the existing NTP data), which we may port in the future to a DataSource Dictionary like the other WebUI in chromium.
Provides any data retrieved or updated to redux store via redux action, but does not use redux actions to ask for a data change.
Also includes
Refactor NTP WebUI backend
Focus on the MessageHandler in order to use FireWebUIListener and follow chromium best practice for setting data and events
TS types for NTP actions
Small change for intellisense™ and action parameter type checking
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Default/Preferencesfile and look forbrave.new_tab_page.show_background_imageand either true/false (depending on what you set in the UI)Reviewer Checklist:
After-merge Checklist:
changes has landed on.