Strip xorigin top-level navigation referrers instead of spoofing #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
fmarier
commented
Apr 17, 2019
| GURL replacement_referrer_url; | ||
| if (!is_main_frame) { | ||
| // But iframe navigations get spoofed instead (brave/brave-browser#3988). | ||
| replacement_referrer_url = request_url.GetOrigin(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
@fmarier Fine, I'm ok with the change. Just curious, does it weaken user privacy after all?
|
There are conflicts and test failures |
Fixes brave/brave-browser#3422. This is based on the #2070 pull request which was committed in 501f4e0 and then reverted in 056ce15 because of brave/brave-browser#3988.
fmarier
force-pushed
the
francois-3422-referrer-stripping2
branch
from
b73c679 to
737ba14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3422.
This is based on the #2070 pull request which was committed in 501f4e0 and then reverted in 056ce15 because of brave/brave-browser#3988.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
This can be manually tested using https://fmarier.github.io/brave-testing/referrer-spoofing.html.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.