Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded YouTube videos no longer work #3988

Closed
bbondy opened this issue Apr 3, 2019 · 4 comments
Closed

embedded YouTube videos no longer work #3988

bbondy opened this issue Apr 3, 2019 · 4 comments
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields feature/video

Comments

@bbondy
Copy link
Member

bbondy commented Apr 3, 2019

Description

This regressed in 0.63.x.

There is such a video at the bottom of this page:
https://www.dailywire.com/news/45415/tucker-carlson-unloads-ocasio-cortez-moron-nasty-ryan-saavedra

@bbondy bbondy self-assigned this Apr 3, 2019
@bsclifton bsclifton added feature/shields/adblock Blocking ads & trackers with Shields feature/video labels Apr 3, 2019
@bbondy
Copy link
Member Author

bbondy commented Apr 4, 2019

@rebron
Copy link
Collaborator

rebron commented Apr 4, 2019

Related: #4009 Includes location and text for YouTube switch.

@bbondy
Copy link
Member Author

bbondy commented Apr 5, 2019

This seems to be not needed because it works on Release channel, so we just introduced a bug on Nightly and Dev. We do need to fix the bug though, so keeping this open.

@rebron rebron changed the title Add a switch to allow embedded YouTube videos embedded YouTube videos no longer work Apr 5, 2019
@bbondy
Copy link
Member Author

bbondy commented Apr 6, 2019

Fixed by reverting #3988
here brave/brave-core#2175

@bbondy bbondy closed this as completed Apr 6, 2019
fmarier added a commit to brave/brave-core that referenced this issue Apr 16, 2019
Fixes brave/brave-browser#3422.

This is based on the #2070 pull request which
was committed in 501f4e0 and
then reverted in 056ce15 because
of brave/brave-browser#3988.
fmarier added a commit to brave/brave-core that referenced this issue Apr 17, 2019
Fixes brave/brave-browser#3422.

This is based on the #2070 pull request which
was committed in 501f4e0 and
then reverted in 056ce15 because
of brave/brave-browser#3988.
fmarier added a commit to brave/brave-core that referenced this issue Apr 26, 2019
Fixes brave/brave-browser#3422.

This is based on the #2070 pull request which
was committed in 501f4e0 and
then reverted in 056ce15 because
of brave/brave-browser#3988.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields feature/video
Projects
None yet
Development

No branches or pull requests

3 participants