Strip xorigin navigation referrers instead of spoofing #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
commented
Mar 25, 2019
|
|
||
| // Same-origin navigations get full referrers. | ||
| const GURL kSameOriginRequest("http://document.com/different/path"); | ||
| referrer = kReferrer; |
There was a problem hiding this comment.
That's the fix for the test failure.
fmarier
commented
Mar 25, 2019
|
|
||
| // Special rule for extensions. | ||
| const GURL kExtensionUrl("chrome-extension://abc/path?query"); | ||
| referrer = kReferrer; |
There was a problem hiding this comment.
That will ensure that this test doesn't start failing for obscure reasons in the future if we add another test before it.
iefremov
approved these changes
Mar 26, 2019
19 tasks
fmarier
added a commit
that referenced
this pull request
Apr 16, 2019
Fixes brave/brave-browser#3422. This is based on the #2070 pull request which was committed in 501f4e0 and then reverted in 056ce15 because of brave/brave-browser#3988.
fmarier
added a commit
that referenced
this pull request
Apr 17, 2019
Fixes brave/brave-browser#3422. This is based on the #2070 pull request which was committed in 501f4e0 and then reverted in 056ce15 because of brave/brave-browser#3988.
28 tasks
fmarier
added a commit
that referenced
this pull request
Apr 26, 2019
Fixes brave/brave-browser#3422. This is based on the #2070 pull request which was committed in 501f4e0 and then reverted in 056ce15 because of brave/brave-browser#3988.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3422.
This is the same as #1767, which was reverted in #2049, but with a small fix to the failing test.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
This can be manually tested using https://fmarier.github.io/brave-testing/referrer-spoofing.html.
Reviewer Checklist: