Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Share Sheet Edit is broken for custom items (uplift to 1.64.x) #22450

Merged
merged 3 commits into from
Mar 5, 2024
Merged

[iOS] Share Sheet Edit is broken for custom items (uplift to 1.64.x) #22450

merged 3 commits into from
Mar 5, 2024

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Mar 4, 2024 •
edited by kjozwiak
Loading

Uplift of #22438
Resolves brave/brave-browser#36506

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 4, 2024
@soner-yuksel soner-yuksel self-assigned this Mar 4, 2024
@soner-yuksel soner-yuksel requested a review from a team as a code owner March 4, 2024 21:51
@soner-yuksel soner-yuksel mentioned this pull request Mar 4, 2024
Merged
24 tasks
@soner-yuksel soner-yuksel mentioned this pull request Mar 5, 2024
Merged
24 tasks
@kjozwiak kjozwiak added this to the 1.64.x - Beta milestone Mar 5, 2024
kjozwiak
kjozwiak approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍 QA has verified the PR on Nightly using 1.65.x as per #22438 (comment).

@kjozwiak kjozwiak merged commit b497a4f into 1.64.x Mar 5, 2024
14 checks passed
@kjozwiak kjozwiak deleted the pr22438_ios_share_sheet_edit_broken_1.64.x branch March 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@soner-yuksel @kjozwiak