Sharesheet menu is broken, Copy Clean Link and Report a Broken Site can't be added to the Favorites

[hffvld]

Description:

Follow-up to brave/brave-ios#8070

Steps to Reproduce

1. Launch Brave 1.63 or newer
2. Go to any website
3. Tap the Share button > Edit Actions...
4. Add Copy Clean Link to the Favorites > Done > Observe Copy Clean Link is not shown in the Favorites
5. Tap Edit Actions... > Observe Copy Clean Link is not shown anymore
6. Add Report a Broken Site > Done > Observe Report a Broken Site is not added to the Favorites

Actual result:

Observed that:

• Copy Clean Link disappeared from the list when trying to add it to the Favorites
• Other items like Report a Broken Site can't be added to the Favorites

There is no option to restore the settings and see Copy Clean Link again. I checked Chrome/Safari and could add any item to the Favorites in both browsers and no items were hidden.

Copy Clean Link

2024-02-29_16-42-57.mp4

Report a Broken Site

2024-02-29_15-50-56.mp4

Expected result:

Copy Clean Link must be available in the list on Sharesheet and can be added to the Favorites.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.63 (161)
BraveCore: 1.63.161 (122.0.6261.57)

• Can you reproduce this issue with the most recent build from TestFlight? YES
• Can you reproduce this issue with the previous version of the current build from TestFlight? YES
• Can you reproduce this issue with the current build from AppStore? YES

Device details:

- iPhone 14 / iOS 17.4 (21E217)
- iPad Air / iPadOS 16.7.2

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

cc @soner-yuksel

[kjozwiak]

The above requires 1.63.169 or higher for 1.63.x verification 👍

[hffvld]

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.63 (169)
BraveCore: 1.63.169 (122.0.6261.111)

---

Fresh profile

STEPS:

1. Follow the steps from Sharesheet menu is broken, Copy Clean Link and Report a Broken Site can't be added to the Favorites #36506 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that Copy Clean Link is shown in the sharesheet menu
• Verified that Copy Clean Link can be added to the Favorites and is not removed from the list
• Verified that Copy Clean Link is working as expected
• Verified that all Brave items from the list can be added to the Favorites

---

1	2

Clean.link.mp4

Upgraded profile

STEPS:

1. Install and launch Brave 1.62.1
2. Go to any website > Tap the Share button > Edit Actions... > Confirm Copy Clean Link is not shown here
3. Add Report a Broken Site to the Favorites
4. Done > Observe Report a Broken Site is not added to the Favorites
5. Upgrade Brave to 1.63 (169) or newer build
6. Tap the Share button > Verify that Copy Clean Link is shown here
7. Edit Actions... > Add Copy Clean Link and Report a Broken Site to the Favorites
8. Done > Verify Copy Clean Link is not disappearing anymore and any Brave item, can be added to the Favorites

---

2024-03-07_12-21-00.mp4