Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Share Sheet Edit is broken for custom items #22438

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Mar 3, 2024

Resolves brave/brave-browser#36506

Looks like this is broken from the beginning but latest changes showed the menu item disappear instead of moving to top.
The activity type has to be set in order to have share sheet item work properly.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Launch Brave 1.63 or newer
  • Go to any website
  • Tap the Share button > Edit Actions...
  • Add Copy Clean Link to the Favorites > Done > Observe Copy Clean Link is not shown in the Favorites
  • Tap Edit Actions... > Observe Copy Clean Link is not shown anymore
  • Add Report a Broken Site > Done > Observe Report a Broken Site is properly added

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 3, 2024
@soner-yuksel soner-yuksel self-assigned this Mar 3, 2024
@soner-yuksel soner-yuksel requested a review from a team as a code owner March 3, 2024 21:35
@soner-yuksel soner-yuksel force-pushed the ios/bugfix/editsharemenu branch from fea33dd to 7fa0738 Compare March 3, 2024 21:52
@brave brave deleted a comment from github-actions bot Mar 3, 2024
@soner-yuksel soner-yuksel force-pushed the ios/bugfix/editsharemenu branch from e30a132 to 6e78617 Compare March 4, 2024 20:28
@soner-yuksel soner-yuksel merged commit f7e620b into master Mar 4, 2024
19 checks passed
@soner-yuksel soner-yuksel deleted the ios/bugfix/editsharemenu branch March 4, 2024 21:38
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Mar 4, 2024
@soner-yuksel soner-yuksel changed the title Share Sheet Edit is broken for custom items [iOS] Share Sheet Edit is broken for custom items Mar 4, 2024
@srirambv
Copy link
Contributor

srirambv commented Mar 5, 2024

Verification passed on iPhone 7+ with iOS 15.8.1 running 1.65 (56)

  • Verified steps from issue description and PR
  • Verified able to add custom items from actions
  • Verfied Copy clean link and Report broken site is added properly into favourites
22438.MP4

kjozwiak pushed a commit that referenced this pull request Mar 5, 2024
…22450)

* Merge pull request #22438 from brave/ios/bugfix/editsharemenu

* Fixing Add Favourites Activity identifier

* Fixing Create PDF has wrong icon in Share menu
kjozwiak pushed a commit that referenced this pull request Mar 5, 2024
…22451)

* Merge pull request #22438 from brave/ios/bugfix/editsharemenu

* Fixing Add Favourites Activity identifier

* Fixing Create PDF has wrong icon in Share menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharesheet menu is broken, Copy Clean Link and Report a Broken Site can't be added to the Favorites
3 participants