-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Share Sheet Edit is broken for custom items #22438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soner-yuksel
added
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
labels
Mar 3, 2024
soner-yuksel
force-pushed
the
ios/bugfix/editsharemenu
branch
from
March 3, 2024 21:52
fea33dd
to
7fa0738
Compare
kylehickinson
requested changes
Mar 3, 2024
soner-yuksel
force-pushed
the
ios/bugfix/editsharemenu
branch
from
March 4, 2024 20:28
e30a132
to
6e78617
Compare
kylehickinson
approved these changes
Mar 4, 2024
soner-yuksel
added a commit
that referenced
this pull request
Mar 4, 2024
7 tasks
soner-yuksel
added a commit
that referenced
this pull request
Mar 4, 2024
7 tasks
soner-yuksel
changed the title
Share Sheet Edit is broken for custom items
[iOS] Share Sheet Edit is broken for custom items
Mar 4, 2024
24 tasks
Verification passed on iPhone 7+ with iOS 15.8.1 running 1.65 (56)
22438.MP4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#36506
Looks like this is broken from the beginning but latest changes showed the menu item disappear instead of moving to top.
The activity type has to be set in order to have share sheet item work properly.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: